ucm2: sof-soundwire - add support for new main capture switch and main capture volume control #67
Conversation
|
Upstream kernel discussion: https://lore.kernel.org/alsa-devel/7d74544f-77f2-db01-db3d-d1d8a56d576d@linux.intel.com/T/#t |
|
perry@perry-$ amixer controls |
ucm2/sof-soundwire/rt715.conf
Outdated
| @@ -4,17 +4,17 @@ SectionDevice."Mic" { | |||
| Comment "SoundWire microphones" | |||
|
|
|||
| EnableSequence [ | |||
| cset "name='PGA5.0 5 Master Capture Switch' 1" | |||
| cset "name='rt715 Main Capture Switch' 1" | |||
There was a problem hiding this comment.
As @perexg said, the patch is still in discussion. And if ALSA finally accepts the kernel patch, I suggested using 'If'. This can help not block the previous projects.
There was a problem hiding this comment.
agreed!
I will update this PR with condition judgment to avoid impacting old platforms.
There was a problem hiding this comment.
As @perexg said, the patch is still in discussion. And if ALSA finally accepts the kernel patch, I suggested using 'If'. This can help not block the previous projects.
Hi @libinyang
I update PR with if judgment added.
It is not tested yet and need to be optimized.
Please help to take a look if the judgement framework is good to go.
…n capture volume control This patch was added for its new main capture switch and main capture volume control which combine the ADC 07 / ADC 27 Capture and Volume switch ,the new mute switch and volume control will be handled by codec rt715`s driver mute/volume kcontrol instead of PGA5. BugLink: thesofproject/linux#2544 Signed-off-by: Perry Yuan <perry_yuan@dell.com>
| If.driver { | ||
| Condition { | ||
| Type String | ||
| Empty "${var:MicMute}" |
There was a problem hiding this comment.
@GoPerry The rt715 patch is merged https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-5.13&id=dcca646c4977d885af3466b454df97b9cb0e0d26
However, from the patch, 'rt715 Main Capture' is not related to the "class/leds/privacy::micmute". This means even without "class/leds/privacy::micmute", 'rt715 Main Capture' still can be used. Or even with "class/leds/privacy::micmute", 'rt715 Main Capture' may not be supported. It is better to test 'rt715 Main Capture' itself, such as "ControlExists". Please refer: https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/sof-hda-dsp/sof-hda-dsp.conf
Fixes: #67 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Fixes: #67 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Fixes: #67 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
This patch was added for its new main capture switch and main capture
volume control which combine the ADC 07 / ADC 27 Capture and Volume
switch ,the new mute switch and volume control will be handled by codec
rt715`s driver mute/volume kcontrol instead of PGA5.
BugLink: thesofproject/linux#2544
Signed-off-by: Perry Yuan perry_yuan@dell.com