Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad vumeter data in aplay/arecord #57

Closed
SuitableUsername opened this issue Sep 22, 2020 · 1 comment
Closed

Bad vumeter data in aplay/arecord #57

SuitableUsername opened this issue Sep 22, 2020 · 1 comment

Comments

@SuitableUsername
Copy link

In aplay.c the wrong count is passed to compute_max_peak(). Instead of "r * hwparams.channels" it should be "r * bits_per_frame / 8".

Also, the vumeter should really show an overall peak level percentage because the transitory 1/8 second one has very little value.
perexg added a commit that referenced this issue Oct 15, 2020
@perexg
aplay: fix the wrong count in compute_max_peak() for 16bit+ sample wi…
246e132 
…dths

The count argument was renamed to samples to correctly represent
the value meaning. Also, remove the wrong count recalculation lines
for 16-bit, 24-bit and 32-bit samples.

BugLink: #57
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
@perexg
Copy link
Member

perexg commented Oct 15, 2020

Thanks. Fixed in 246e132 .

It's really simple linear vumeter. If you like to see meter history, use '-vvv' argument.

@perexg perexg closed this as completed Oct 15, 2020
lgirdwood pushed a commit to thesofproject/alsa-utils that referenced this issue Dec 3, 2020
@perexg @lgirdwood
aplay: fix the wrong count in compute_max_peak() for 16bit+ sample wi…
7a33287 
…dths

The count argument was renamed to samples to correctly represent
the value meaning. Also, remove the wrong count recalculation lines
for 16-bit, 24-bit and 32-bit samples.

BugLink: alsa-project#57
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@perexg @SuitableUsername