Update test '-a' and '-o' to '&&' and '||'
#206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lines 50, 103: in two compound ['s, replace '-a' with '] && [' SC2166 – Prefer `[ p ] && [ q ]` as `[ p -a q ]` is not well defined. SC2107 – Instead of `[ a && b ]`, use `[ a ] && [ b ]`. line 45: in a compound test command, change '-o' to '|| test' SC1139 – Use `||` instead of `-o` between test commands. SC2109 – Instead of `[ a || b ]`, use `[ a ] || [ b ]`. https://www.shellcheck.net/wiki/SC[0-9]{4}
wileyhy
added a commit
to wileyhy/alsa-utils
that referenced
this pull request
May 5, 2023
lines 50, 103: in two compound ['s, replace '-a' with '] && [' SC2166 – Prefer `[ p ] && [ q ]` as `[ p -a q ]` is not well defined. SC2107 – Instead of `[ a && b ]`, use `[ a ] && [ b ]`. line 45: in a compound test command, change '-o' to '|| test' SC1139 – Use `||` instead of `-o` between test commands. SC2109 – Instead of `[ a || b ]`, use `[ a ] || [ b ]`. ... https://github.com/koalaman/shellcheck Fixes: alsa-project#206 From: wileyhy @ github Signed-off-by: Jaroslav Kysela <perex@perex.cz> /// Performed manual edit during rebase: 1. Altered some quotation marks 2. replace '-a' with '] && [' ///
wileyhy
added a commit
to wileyhy/alsa-utils
that referenced
this pull request
May 5, 2023
Added double quotes to common expansions; removed quotes from strings; changed REQUIRES to an indexed array and changed the corresponding for loop; added curly braces where feasibly necessary; removed a few unnecessary trailing semi-colons; and put URL's in single quotes to prevent any possible expansions, except for within the sed command. Some logic structures depend on word splitting, so I left those as-is for this commit. Double exclamation marks in double quotes allow history expansion which is usually disabled in non-interactive shells, so I left those as-is also. Merging of pull requests alsa-project#206 and alsa-project#207 altered the master branch, so I did a manual edit this pull request during rebase. /// Manual edit during rebase: 1. line ~50, repeat "replace '-a' with '] && ['" ///
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lines 50, 103: in two compound ['s, replace '-a' with '] && ['
SC2166 – Prefer
[ p ] && [ q ]as[ p -a q ]is not well defined.SC2107 – Instead of
[ a && b ], use[ a ] && [ b ].line 45: in a compound test command, change '-o' to '|| test'
SC1139 – Use
||instead of-obetween test commands.SC2109 – Instead of
[ a || b ], use[ a ] || [ b ].https://www.shellcheck.net/wiki/SC[0-9]{4}