Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for test-runner is used before being assigned #396

Closed
wants to merge 1 commit into from
Closed

Fix for test-runner is used before being assigned #396

wants to merge 1 commit into from

Commits on May 22, 2017

  1. Fix for test-runner is used before being assigned 

    Without this change TSC is correctly giving warnings that
`currentTestFixtureResults` and `currentTestResults` are
`used before being assigned`.

Also, with this change but not using stricter compiler option test coverage
is missing for line 89, which means `currentTestResults` is always valid.
But if I put that `then` portion of `if (currentTestResults) {` into
`if (currentTestFixtureResults && (!previousTestItem || previousTestItem.test !== testItem.test)) {`
`_runTests` will fail.

It seems this loop is a little odd and maybe needs some refractoring, but
I'm not sure exactly how it works so I need some guidance.
    @winksaville
    winksaville committed May 22, 2017
    Configuration menu
    Copy the full SHA
    58ec7d1 View commit details
    Browse the repository at this point in the history