Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reexporting RouterEventType from package crayon #45

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

alshdavid
Copy link
Owner

Proposed changes

Reexporting RouterEventType as described in this issue:
https://github.com/alshdavid/crayon/issues/44

Types of changes

What types of changes does your code introduce to Crayon?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@alshdavid alshdavid merged commit 80f98b5 into master Sep 25, 2019
@alshdavid alshdavid deleted the task/ISS-44-export-routerevent-type branch November 30, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant