Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No news so far" message not showing up when news directory is empty #556

Closed
3 tasks done
benjaminh opened this issue Feb 7, 2022 · 1 comment · Fixed by #560
Closed
3 tasks done

"No news so far" message not showing up when news directory is empty #556

benjaminh opened this issue Feb 7, 2022 · 1 comment · Fixed by #560
Labels

Comments

@benjaminh
Copy link

Acknowledge the following

  • I carefully read and followed the Getting Started guide.
  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • The issue I am raising is a potential bug in al-folio and not just a usage question.
    [For usage questions, please post in the Discussions instead of raising an issue.]

Describe the bug
The news section within about page should display No news so far… if there are no news to show up (according to _includes/news.html file). Yet, if the _news directory is empty or has been removed, the message is not showing up.

I fixed the issue by replacing the condition {% if site.news %} by {% if site.news != blank %} and I was wondering if this is a real bug or maybe due to the Jekyll/Ruby version ?

To Reproduce
Steps to reproduce the behavior:

  1. Remove the content in _news directory
  2. Go to the about page
  3. Scroll down to the news section

Expected behavior
The message No news so far… should be displayed as stated in _includes/news.html (line 23).

System (please complete the following information):

  • OS: Ubuntu 20.04
  • Browser (and its version): Firefox 96.0
  • Jekyll version: 4.2.1
  • Ruby version: 3.1.0
@alshedivat
Copy link
Owner

thanks for reporting this. looks like it's a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants