More Environment stuff

Turbinado/Environment.hs

@@ -1,30 +1,47 @@
 module Turbinado.Environment (
   Environment,
-  EnvironmentFilter,
   newEnvironment,
-  getKey,
-  setKey
+  EnvironmentFilter
   ) where
 
-import Data.Dynamic
 import Data.Map
 import Data.Maybe
 import System.IO
-import System.IO.Unsafe
-import System.Log.Logger
+import Config.Master
 
--- Using Dynamic for two reasons:
---  1) Break module cycles (Environment doesn't import the various Request, Response, etc bits
---  2) Extensibility - easy for plugins to add data to the Environment
-type Environment = Map String Dynamic
+import Turbinado.Environment.CodeStore
+import Turbinado.Environment.Logger
+import Turbinado.Environment.MimeTypes
+import Turbinado.Environment.Request
+import Turbinado.Environment.Response
+import Turbinado.Environment.Routes
+import Turbinado.Environment.Settings
+import Turbinado.Environment.ViewData
 
+data Environment = Environment { getCodeStore :: Maybe CodeStore
+                               , getLogger    :: Maybe Logger
+                               , getMimeTypes :: Maybe MimeTypes
+                               , request      :: Maybe Request
+                               , getResponse  :: Maybe Response
+                               , getRoutes    :: Maybe Routes
+                               , getSettings  :: Maybe Settings
+                               , getViewData  :: Maybe ViewData
+                               , getAppEnvironment :: Maybe AppEnvironment
+                               }
+
 type EnvironmentFilter = Environment -> IO Environment
 
 newEnvironment :: IO Environment
-newEnvironment = return (empty :: Environment)
+newEnvironment = return $ Environment { 
+                                 getCodeStore = Nothing
+                               , getLogger    = Nothing
+                               , getMimeTypes = Nothing
+                               , getRequest   = Nothing
+                               , getResponse  = Nothing
+                               , getRoutes    = Nothing
+                               , getSettings  = Nothing
+                               , getViewData  = Nothing
+                               , getAppEnvironment = Nothing
+                               }
+
 
-getKey :: (Typeable a) => String -> Environment -> a
-getKey k e =  fromJust $ fromDynamic $ e ! k
-
-setKey :: (Typeable a) => String -> a -> EnvironmentFilter
-setKey k v = \e -> return $  insert k (toDyn v) e

Turbinado/Environment/CodeStore.hs

@@ -29,7 +29,7 @@ import Config.Master
 
 import qualified Turbinado.Server.Exception as Ex
 import Turbinado.Environment.Logger
-import Turbinado.Environment
+import {-# SOURCE #-} Turbinado.Environment
 import Turbinado.Environment.Request
 import Turbinado.Environment.Response
 import Turbinado.View.Monad

Turbinado/Environment/Logger.hs

@@ -3,7 +3,7 @@ module Turbinado.Environment.Logger where
 import qualified System.Log.Logger as L
 import qualified System.Log.Handler.Simple as S
 import Control.Concurrent.MVar
-import Turbinado.Environment
+import {-# SOURCE #-} Turbinado.Environment
 import Config.Master
 import Data.Dynamic
 

Turbinado/Environment/MimeTypes.hs

@@ -45,7 +45,7 @@ import Data.Typeable
 import qualified Data.Map as Map hiding (Map)
 import Text.ParserCombinators.Parsec
 
-import Turbinado.Environment
+import {-# SOURCE #-} Turbinado.Environment
 
 data MimeTypes = MimeTypes (Map String MimeType)
   deriving (Typeable)

Turbinado/Environment/Request.hs

@@ -12,21 +12,19 @@ import Turbinado.Utility.General
 import qualified Data.Map as M
 import Control.Monad
 import Data.Maybe
-import Turbinado.Environment
+import {-# SOURCE #-} Turbinado.Environment
 
 requestKey = "request"
 
 addRequestToEnvironment :: HTTP.Request -> EnvironmentFilter
 addRequestToEnvironment  = setRequest
 
 getRequest :: Environment -> HTTP.Request
-getRequest = getKey requestKey
+getRequest = fromJust $ request
 
 setRequest :: HTTP.Request -> EnvironmentFilter
-setRequest req = setKey requestKey req
+setRequest req e = return $ e { request = Just req} 
 
-modifyRequest :: (HTTP.Request -> HTTP.Request) -> EnvironmentFilter
-modifyRequest f = getRequest >>= (setRequest . f)
 
 {-
 lookupHeader :: (Monad m) => m (Maybe String)

Turbinado/Environment/Response.hs

@@ -12,7 +12,7 @@ import Turbinado.Utility.General
 import qualified Data.Map as M
 import Control.Monad
 import Data.Maybe
-import Turbinado.Environment
+import {-# SOURCE #-} Turbinado.Environment
 import System.Time
 import System.Locale
 

Turbinado/Environment/Routes.hs

@@ -12,7 +12,7 @@ import Control.Monad
 import qualified Network.HTTP as HTTP
 import qualified Network.URI as URI
 import Turbinado.Controller.Exception
-import Turbinado.Environment
+import {-# SOURCE #-} Turbinado.Environment
 import Turbinado.Environment.Logger
 import Turbinado.Environment.Request
 import Turbinado.Environment.Settings

Turbinado/Environment/Settings.hs

@@ -17,7 +17,7 @@ import Control.Monad.State
 import Data.Maybe
 import Data.Char
 import System.FilePath
-import Turbinado.Environment
+import {-# SOURCE #-} Turbinado.Environment
 
 type Settings = M.Map String Dynamic
 

Turbinado/Environment/ViewData.hs

@@ -7,7 +7,7 @@ module Turbinado.Environment.ViewData (
 import qualified Data.Map as M
 import Control.Monad
 import Data.Maybe
-import Turbinado.Environment
+import {-# SOURCE #-} Turbinado.Environment
 
 type ViewData = Map String Dynamic
 

turbinado.cabal

@@ -12,7 +12,7 @@ Executable server
   Main-is:             Turbinado/Server.hs
   Build-Depends:       base, bytestring, containers, directory, filepath, harp, hslogger, hsx, HTTP, mtl, network, old-locale, old-time, parsec, plugins, pretty, regex-compat, time
   Hs-Source-Dirs:      . , config
-  ghc-options: -F -pgmFtrhsx -O 
+  ghc-options: -O 
   Extensions: MultiParamTypeClasses,
             FunctionalDependencies,
             TypeFamilies,