Reconnect to MQTT broker if connection is dropped #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also need to set clean_session to false, so we don't lose our previous subscriptions.
alsuren
reviewed
Dec 17, 2020
homie-influx/src/main.rs
Outdated
| } | ||
|
|
||
| simplify_unit_vec(try_join_all(join_handles).await) | ||
| simplify_unit_vec(try_join_all(join_handles).await)?; |
There was a problem hiding this comment.
No need to simplify it you are throwing the result away
alsuren
approved these changes
Dec 17, 2020
|
|
||
| const DEFAULT_MQTT_CLIENT_PREFIX: &str = "homie-influx"; | ||
| const DEFAULT_MQTT_HOST: &str = "test.mosquitto.org"; | ||
| const DEFAULT_MQTT_PORT: u16 = 1883; | ||
| const DEFAULT_MQTT_RECONNECT_INTERVAL: Duration = Duration::from_secs(5); |
There was a problem hiding this comment.
How long does it take to get synced up with all the mqtt state? If you were in a fresh loop, what fraction of your time would be spent hammering the server?
There was a problem hiding this comment.
The state is preserved on the broker when clean_session is set to false, so the client just needs to authenticate and connect/conack. WIthout a delay it just seems to constantly try to reconnect. I didn't check CPU usage, but there was certainly a lot of log spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the
homie-influxpart of #7. It also makes errors writing to InfluxDB non-fatal. There is no point crashing just because one database isn't working, as the others may still work.