Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code climate/maintainability #41

Merged
merged 2 commits into from Nov 10, 2019
Merged

Improve code climate/maintainability #41

merged 2 commits into from Nov 10, 2019

Conversation

bravo-kernel
Copy link
Collaborator

Introduces lib/utils/type-checks.js to refactor type checking.

@codecov
Copy link

codecov bot commented Nov 10, 2019

Codecov Report

Merging #41 into master will increase coverage by 4.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage    76.3%   80.42%   +4.12%     
==========================================
  Files           7        8       +1     
  Lines         325      327       +2     
==========================================
+ Hits          248      263      +15     
+ Misses         77       64      -13
Impacted Files Coverage Δ
lib/schema-manager.js 92.12% <100%> (+6.81%) ⬆️
lib/utils/type-checks.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a18a7...583961e. Read the comment docs.

@bravo-kernel bravo-kernel merged commit 4332565 into master Nov 10, 2019
@bravo-kernel bravo-kernel deleted the code-climate branch November 10, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant