Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor + initial test for the StrategyInterface #8

Merged
merged 4 commits into from Aug 24, 2019
Merged

Conversation

bravo-kernel
Copy link
Collaborator

@bravo-kernel bravo-kernel commented Aug 24, 2019

Please note: maxLength for type 'string' MUST be an integer, see 6.3.1

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #8 into master will increase coverage by 0.38%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #8      +/-   ##
=========================================
+ Coverage   71.52%   71.9%   +0.38%     
=========================================
  Files          12      12              
  Lines         302     299       -3     
=========================================
- Hits          216     215       -1     
+ Misses         86      84       -2
Impacted Files Coverage Δ
lib/type-mapper.js 37.63% <33.33%> (-1.95%) ⬇️
lib/strategy-interface.js 27.27% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a954d...9ddd214. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #8 into master will increase coverage by 0.38%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #8      +/-   ##
=========================================
+ Coverage   71.52%   71.9%   +0.38%     
=========================================
  Files          12      12              
  Lines         302     299       -3     
=========================================
- Hits          216     215       -1     
+ Misses         86      84       -2
Impacted Files Coverage Δ
lib/type-mapper.js 37.63% <33.33%> (-1.95%) ⬇️
lib/strategy-interface.js 27.27% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a954d...9ddd214. Read the comment docs.

@bravo-kernel bravo-kernel changed the title Simplify Refactor + initial test for the StrategyInterface Aug 24, 2019
@bravo-kernel bravo-kernel merged commit b466827 into master Aug 24, 2019
@bravo-kernel bravo-kernel deleted the simplify branch August 24, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant