cleanups

altair-graphql · Jun 15, 2024 · 572d5b8 · 572d5b8
1 parent 1e213bc
commit 572d5b8
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 28 deletions.
diff --git a/packages/altair-app/src/app/modules/altair/services/gql/gql.service.ts b/packages/altair-app/src/app/modules/altair/services/gql/gql.service.ts
@@ -765,7 +765,7 @@ export class GqlService {
     additionalParams,
     handler = new HttpRequestHandler(),
   }: SendRequestOptions): Observable<SendRequestResponse> {
-    // wrapping rhe logic to properly handle any errors (both within and outside the observable)
+    // wrapping the logic to properly handle any errors (both within and outside the observable)
     return of(undefined).pipe(
       switchMap(() => {
         const { resolvedFiles } = this.normalizeFiles(files);

diff --git a/packages/altair-app/src/assets/i18n/default.json b/packages/altair-app/src/assets/i18n/default.json
@@ -91,7 +91,7 @@
   "REQUEST_HANDLER_GRAPHQL_SSE": "Graphql over SSE",
 
   "DEFAULT_REQUEST_HANDLER_TITLE": "Default Request Handler",
-  "REQUEST_HANDLER_PARAMS_TEXT": "Parameters (in JSON",
+  "REQUEST_HANDLER_PARAMS_TEXT": "Parameters (in JSON)",
 
   "HISTORY_TEXT": "History",
   "HISTORY_CLEAR_TEXT": "Clear History",

diff --git a/packages/altair-core/package.json b/packages/altair-core/package.json
@@ -37,7 +37,6 @@
     "@types/jest": "^29.5.12",
     "@types/node": "^14.14.41",
     "@types/uuid": "^9.0.5",
-    "@types/whatwg-mimetype": "^3.0.2",
     "@typescript-eslint/eslint-plugin": "^7.4.0",
     "@typescript-eslint/parser": "^7.4.0",
     "ajv-cli": "5.0.0",

diff --git a/packages/altair-core/src/request/handlers/graphql-ws.ts b/packages/altair-core/src/request/handlers/graphql-ws.ts
@@ -10,18 +10,6 @@ import { simpleResponseObserver } from '../utils';
 export class GraphQLWsRequestHandler implements GraphQLRequestHandler {
   client?: Client;
   cleanup?: () => void;
-  onConnected(
-    subscriber: Subscriber<GraphQLResponseData>,
-    error: unknown,
-    data: unknown
-  ) {
-    if (error) {
-      console.log('Subscription connection error', error);
-      subscriber.error(error);
-      return;
-    }
-    console.log('Connected subscription.');
-  }
 
   handle(request: GraphQLRequestOptions): Observable<GraphQLResponseData> {
     return new Observable((subscriber) => {

diff --git a/packages/altair-core/src/request/response-builder.ts b/packages/altair-core/src/request/response-builder.ts
@@ -185,15 +185,15 @@ const patchResponse = (
 
       const path = ['data', ...patch.path];
       if ('data' in patch) {
-        // defer patch
+        // @defer patch
         // set the data at the path in result
         if (patch.data) {
           result.data = result.data ?? {};
           setByDotNotation(result, path, patch.data, true);
         }
       }
       if ('items' in patch) {
-        // stream patch
+        // @stream patch
         patch.items?.forEach((item, i) => {
           const lastPathIdx = path[path.length - 1];
           if (typeof lastPathIdx !== 'number') {

diff --git a/packages/altair-core/src/types/state/query.interfaces.ts b/packages/altair-core/src/types/state/query.interfaces.ts
@@ -14,12 +14,6 @@ export interface QueryResponse {
   timestamp: number;
 }
 
-export interface SubscriptionResponse {
-  response: string;
-  responseObj: unknown;
-  responseTime: number;
-}
-
 export interface LogLine {
   time: number;
   text: string;

diff --git a/yarn.lock b/yarn.lock
@@ -9066,11 +9066,6 @@
   resolved "https://registry.yarnpkg.com/@types/web-bluetooth/-/web-bluetooth-0.0.20.tgz#f066abfcd1cbe66267cdbbf0de010d8a41b41597"
   integrity sha512-g9gZnnXVq7gM7v3tJCWV/qw7w+KeOlSHAhgF9RytFyifW6AF61hdT2ucrYhPq9hLs5JIryeupHV3qGk95dH9ow==
 
-"@types/whatwg-mimetype@^3.0.2":
-  version "3.0.2"
-  resolved "https://registry.yarnpkg.com/@types/whatwg-mimetype/-/whatwg-mimetype-3.0.2.tgz#e5e06dcd3e92d4e622ef0129637707d66c28d6a4"
-  integrity sha512-c2AKvDT8ToxLIOUlN51gTiHXflsfIFisS4pO7pDPoKouJCESkhZnEy623gwP9laCy5lnLDAw1vAzu2vM2YLOrA==
-
 "@types/which@^1.3.2":
   version "1.3.2"
   resolved "https://registry.yarnpkg.com/@types/which/-/which-1.3.2.tgz#9c246fc0c93ded311c8512df2891fb41f6227fdf"