Skip to content

Commit

Permalink
Fixed getAltairHtml bug with resolving path.
Browse files Browse the repository at this point in the history
  • Loading branch information
imolorhe committed Dec 15, 2019
1 parent beaeffb commit 6238bdc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
5 changes: 1 addition & 4 deletions packages/altair-static/src/index.ts
Expand Up @@ -115,9 +115,6 @@ function getObjectPropertyForOption(option: any, propertyName: string) {
return '';
}

/**
* Returns the path to Altair assets, for resolving the assets when rendering Altair
*/
export const getDistDirectory = () => resolve(__dirname, 'dist');
export { getDistDirectory } from './utils/get-dist';

export default renderAltair;
3 changes: 2 additions & 1 deletion packages/altair-static/src/utils/get-altair-html.ts
@@ -1,6 +1,7 @@
import { readFileSync } from 'fs';
import { resolve } from 'path';
import { getDistDirectory } from './get-dist';

export default function getAltairHtml() {
return readFileSync(resolve(__dirname, 'dist/index.html'), 'utf8');
return readFileSync(resolve(getDistDirectory(), 'index.html'), 'utf8');
}
6 changes: 6 additions & 0 deletions packages/altair-static/src/utils/get-dist.ts
@@ -0,0 +1,6 @@
import { resolve } from 'path';

/**
* Returns the path to Altair assets, for resolving the assets when rendering Altair
*/
export const getDistDirectory = () => resolve(__dirname, '../dist');

0 comments on commit 6238bdc

Please sign in to comment.