Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent errors at "Reload Docs" (no any visual information about error server error in Altair) #1071

Closed
XAKEPEHOK opened this issue Nov 19, 2019 · 6 comments
Milestone

Comments

@XAKEPEHOK
Copy link

I am backend-developer, and in development process of GraphQL API, I often need to Reload Docs in Altair. Sometimes, my changes bring to 500 server error, but if I click to "Reload Docs" nothing happens (no any visual information about error in Altair)

To Reproduce
Steps to reproduce the behavior:

  1. Set endpoint, that return 500 error
  2. Click on "Reload Docs"
  3. Nothing happens

Expected behavior
I think, that it is a good practice, to show some visible error

Screenshots
http://screenshot.lvcdn.ru/7b0a05bac9.png

Desktop (please complete the following information):

  • OS: Windows 10 Pro
  • Browser Chrome
  • Version 78.0.3904.97
@welcome
Copy link

welcome bot commented Nov 19, 2019

👋🏾Thanks for opening your first issue here! Be sure to follow the issue template! ✌🏾

@imolorhe
Copy link
Collaborator

imolorhe commented Dec 5, 2019

Thanks for reporting this! I'd look into it as soon as I can.

@imolorhe imolorhe added this to the v2.4.0 milestone Dec 8, 2019
@XAKEPEHOK
Copy link
Author

Hello, @imolorhe
Same behavior at 2.4.9. No any visual information about error server error
Browser ext, Chrome dev v85.0.4158.4

@imolorhe
Copy link
Collaborator

imolorhe commented Jun 6, 2020

Hey @XAKEPEHOK is this specific to v2.4.9?

@XAKEPEHOK
Copy link
Author

XAKEPEHOK commented Jun 11, 2020

I can't understand why, but sometimes, some errors are silent, and some errors has warnings in Altair GUI.

See video http://screenshot.lvcdn.ru/625bc03647.mp4

OS: Windows 10 Pro
Browser Chrome
Version 85.0.4164.4 dev

@imolorhe imolorhe modified the milestones: v2.4.0, v2.4.10 Jun 13, 2020
@imolorhe
Copy link
Collaborator

@XAKEPEHOK The issue you're experiencing was caused by a bug in the disableWarnings logic introduced in v2.4.9. I've changed it to display network issues as errors, and not warnings. Also fixed the issue with disableWarnings.

imolorhe added a commit that referenced this issue Jun 13, 2020
Changed misleading warnings to errors.
Closes #1071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants