Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #1034

Merged
merged 51 commits into from
Oct 26, 2019
Merged

Staging #1034

merged 51 commits into from
Oct 26, 2019

Conversation

imolorhe
Copy link
Collaborator

No description provided.

tudoramariei and others added 30 commits October 14, 2019 15:30
The `CONTRIBUTING.md` was moved to `.github`  in change commit 96d7d1c but the `README` wasn't updated
Correcting this to make life better for anyone going to the `README` in order to find that document
Update @types/chrome to the latest version 🚀
…rbin

docs: add vladshcherbin as a contributor
Update ng-zorro-antd to the latest version 🚀
Changed electron app name back to altair.
MathewtheCoder and others added 19 commits October 19, 2019 00:55
…log-keybinding

Added keyboard shortcut for displaying settings dialog.
Only add query params for GET requests if not empty
issue mentioned in #968, #1019.
Disabled electron tests for now. Need to figure out the right versions
for libraries (chromedriver).
Upgraded to electron 7.0.0
Update ng-zorro-antd to the latest version 🚀
@request-info
Copy link

request-info bot commented Oct 26, 2019

The maintainers of this repository would appreciate it if you could provide more information.

autoUpdater.autoDownload = false;

autoUpdater.on('error', (error) => {
dialog.showErrorBox('Error: ', error == null ? 'unknown' : (error.stack || error).toString());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected '===' and instead saw '=='.

@imolorhe imolorhe merged commit ab79bff into master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants