Feature/reopen closed tabs 999 #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏾Thanks for opening this pull request! Please check out our contributing guidelines.👊🏾😁 |
|
Hey, thanks for the PR. Did you test that this actually works? |
|
Hey |
Fixed reopen closed window implementation.
imolorhe
reviewed
Nov 2, 2019
src/app/components/window-switcher/window-switcher.component.ts
Outdated
Show resolved
Hide resolved
3b3ziz
reviewed
Nov 2, 2019
|
@imolorhe I set the What do you think? |
|
I think you should set it after setting the window IDs. Not before. Also let me guess you're also working with @abdelrhman-arnos |
yep |
|
Congrats on merging your first pull request! 🙌🏾🎉🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Add "Reopen closed tab" functionality - 999
...
Checks
npm run test-buildChanges proposed in this pull request: