Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammatical fix in 'Install Updates' message #1140

Merged
merged 1 commit into from
Dec 29, 2019
Merged

Minor grammatical fix in 'Install Updates' message #1140

merged 1 commit into from
Dec 29, 2019

Conversation

connorads
Copy link
Contributor

Fixes

Minor grammatical fix in 'Install Updates' message
image

Checks

  • [❌] Ran npm run test-build

I did this but it failed for some reason in graphql-linter.
I'm assuming this is not related to my very small change!
image

Changes proposed in this pull request:

  • Minor grammatical fix in 'Install Updates' message

@welcome
Copy link

welcome bot commented Dec 29, 2019

👋🏾Thanks for opening this pull request! Please check out our contributing guidelines.👊🏾😁

@imolorhe
Copy link
Collaborator

You probably have a typescript version different from the one used in the project.

@imolorhe imolorhe merged commit 2659ce4 into altair-graphql:staging Dec 29, 2019
@welcome
Copy link

welcome bot commented Dec 29, 2019

Congrats on merging your first pull request! 🙌🏾🎉🎊

@connorads
Copy link
Contributor Author

You probably have a typescript version different from the one used in the project.

Yes I used npm install and it made me a new package-lock.json with TypeScript 3.7.4 which didn't work.
Following that I started playing with version numbers and got into a bit of a mess before realising there was a yarn.lock file.

I did yarn install instead and everything worked fine 😄

Thanks!

@imolorhe
Copy link
Collaborator

Awesome! Always great when the tools work as they are expected 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants