New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging #1248

Merged

imolorhe merged 31 commits into master from staging

May 24, 2020

Collaborator

imolorhe commented May 24, 2020

Merging staging to master

imolorhe and others added 30 commits

May 6, 2020 20:52


          New translations default.json (Vietnamese)

1e66c9f


          Merge pull request #1241 from imolorhe/l10n_staging

89da14d

New Crowdin translations


          fix: docs/Gemfile & docs/Gemfile.lock to reduce vulnerabilities

69a719f

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-569598


          fix: docs/Gemfile & docs/Gemfile.lock to reduce vulnerabilities

5d08c29

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-569598


          Merge pull request #1246 from imolorhe/snyk-fix-1ad201f99bb205392e4a6…

d0b9048

…1891d20569c

[Snyk] Security upgrade github-pages from 202 to 203


          Added apt update before deploy to install latest snapd in travis ci

90a1f05

Added option to preventDuplicate alerts. Closes #1244.
Added original error messages to alerts. Closes #1244.
Added option to disable warning alerts. Closes #1242.


          Updated angular modules.

243406e

Generated settings schema


          Updated @angular packages

cddb88e


          Updated ngrx-store-localstorage

cf7511d


          Removed @angular/http

51294eb


          Updated dependencies

8314b53


          Fixed migration issues

bf4d1a2


          Added migration changes

1145bed


          Fixed typescript errors

3d0b63c


          Fixed broken specs

2a1d6bc


          Fixed linting errors

7431bcb


          Fixed electtron tests

1ea1755


          Update chrome driver to v83

0dfd695


          Close any open backdrops

d783dd4


          Trying isClickable API

fb72f12


          Removes isClickable

b370905


          Merge pull request #1247 from imolorhe/to-angularv9

d24217e

To angularv9


          Temporarily release snap on staging

8e2b54a


          Try snap edge channel

e82b376


          Switch back to stable

194e8e0


          Try setting classic to true


          Build electron in linux

caf3148


          Deploy snap on tag only

2b4fb65


          Updated settings pane docs

74aa46d


          Updated to v2.4.8

274cfd8

hound bot reviewed

View reviewed changes

packages/altair-app/src/app/utils/validate_settings_schema.js

+                                              }];
+                                              return false;
+                                            }
+                                            var valid1 = errors === errs_1;

hound bot May 24, 2020

'valid1' is already defined.

packages/altair-app/src/app/utils/validate_settings_schema.js

+                                          if (data['theme.fontsize'] === undefined) {
+                                            valid1 = true;
+                                          } else {
+                                            var errs_1 = errors;

hound bot May 24, 2020

'errs_1' is already defined.

packages/altair-app/src/app/utils/validate_settings_schema.js

+                                          }];
+                                          return false;
+                                        }
+                                        var valid2 = errors === errs_2;

hound bot May 24, 2020

'valid2' is already defined.

packages/altair-app/src/app/utils/validate_settings_schema.js

+                                        var valid2;
+                                        valid2 = false;
+                                        for (var i2 = 0; i2 < schema2.length; i2++)
+                                          if (equal(data1, schema2[i2])) {

hound bot May 24, 2020

Expected '{' and instead saw 'if'.

packages/altair-app/src/app/utils/validate_settings_schema.js

+                                        var schema2 = refVal2.enum;
+                                        var valid2;
+                                        valid2 = false;
+                                        for (var i2 = 0; i2 < schema2.length; i2++)

hound bot May 24, 2020

'i2' is already defined.

packages/altair-app/src/app/utils/validate_settings_schema.js

+                                  var errs__1 = errors;
+                                  var valid1;
+                                  for (var i1 = 0; i1 < data1.length; i1++) {
+                                    var errs_2 = errors;

hound bot May 24, 2020

'errs_2' is already defined.

packages/altair-app/src/app/utils/validate_settings_schema.js

-                                if (typeof data['request.withCredentials'] !== "boolean") {
+                                if (Array.isArray(data1)) {
+                                  var errs__1 = errors;
+                                  var valid1;

hound bot May 24, 2020

'valid1' is already defined.

packages/altair-app/src/app/utils/validate_settings_schema.js

                                 valid1 = true;
                               } else {
                                 var errs_1 = errors;
-                                if (typeof data['request.withCredentials'] !== "boolean") {
+                                if (Array.isArray(data1)) {
+                                  var errs__1 = errors;

hound bot May 24, 2020

'errs__1' is defined but never used.

packages/altair-app/src/app/utils/validate_settings_schema.js

                               var valid1 = errors === errs_1;
                             }
                             if (valid1) {
-                              if (data['request.withCredentials'] === undefined) {
+                              var data1 = data['plugin.list'];

hound bot May 24, 2020

'data1' is already defined.

packages/altair-app/src/app/utils/validate_settings_schema.js

+                                }];
+                                return false;
+                              }
+                              var valid2 = errors === errs_2;

hound bot May 24, 2020

'valid2' is already defined.


          Merge branch 'master' into staging

64af813

hound bot reviewed

View reviewed changes

packages/altair-app/src/app/utils/validate_settings_schema.js

+                              var valid2;
+                              valid2 = false;
+                              for (var i2 = 0; i2 < schema2.length; i2++)
+                                if (equal(data1, schema2[i2])) {

hound bot May 24, 2020

Expected '{' and instead saw 'if'.

docs/Gemfile

@@ @@ -10,7 +10,7 @@ source "https://rubygems.org" @@
               # Happy Jekylling!
               # gem "jekyll", "3.5.1"
-              gem "github-pages", ">= 200", group: :jekyll_plugins
+              gem "github-pages", ">= 203", group: :jekyll_plugins

hound bot May 24, 2020

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

imolorhe merged commit b715a89 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment