Correct object handling in altair-static render function #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏾Thanks for opening this pull request! Please check out our contributing guidelines.👊🏾😁 |
|
Hey @codeitcody, thanks for the PR. It's strange how this has gone under the radar for a while now. 😅 |
imolorhe
approved these changes
Sep 3, 2020
|
Congrats on merging your first pull request! 🙌🏾🎉🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1338
This fixes an issue with how altair-static rendered stringified JSON objects. It was incorrectly rendering JSON objects by surrounding the stringified object with template string quotes (` ... `):
In addition to the above fix, this PR also includes the
initialSettingsin the rendering which was previously missing.Checks
yarn test-buildinitialHeadersandinitialSettingsoptions to test spec.altair-koa-middlewarecorrectly rendered withinitialHeadersandinitialSettings.Changes proposed in this pull request:
initialSettingsoption to init options in altair-static.