Staging #1624
Merged
Staging #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed altair-exported-types. altair-exported-types was a temporary hack to getting Altair types available for the other packages like altair-static. As it turns out exporting types only from a typescript project introduces other issues since the type implementations are not exported as well. Things like enums do not get typed properly when used and they need the provided strings to be recast as the enum type which defeats the purpose of having the types in the first place. For example, `PluginSource` which includes `NPM` would now have to be typed as `'NPM' as PluginSource` which also means you do not get the autocomplete options to ensure the string you are passing is indeed a valid value for that enum. This also affects classes as well which would no longer be extendable but can only be implemented as an interface.
Added altair-graphql-core
Updated repo references to include altair-graphql
Refactored plugin logic structure a bit
Fixed bug when changing instanceStorageNamespace
…e-button Update environment delete button to be more obvious
Added option for also setting dark mode theme
|
Visit the preview URL for this PR (updated for commit 6ff1f9f): https://altair-gql--pr1624-staging-niva9jkk.web.app (expires Tue, 20 Jul 2021 07:03:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging staging to master