Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import multiple collection files at once #1692

Merged
merged 7 commits into from Oct 8, 2021
Merged

feat: import multiple collection files at once #1692

merged 7 commits into from Oct 8, 2021

Conversation

eole1712
Copy link
Contributor

@eole1712 eole1712 commented Sep 28, 2021 •
edited

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

  • Import several collection files at once

@eole1712 eole1712 changed the title feat: multiple collections feat: import multiple collection files at once Sep 28, 2021
imolorhe
imolorhe requested changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@imolorhe imolorhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes! Overall the changes look good to me. Left a few comments though. Once those are updated and the build is passing, I'm happy to approve this PR!

packages/altair-app/src/app/modules/altair/utils/index.ts Outdated Show resolved Hide resolved
packages/altair-app/src/app/modules/altair/utils/index.ts Outdated Show resolved Hide resolved
packages/altair-app/src/app/modules/altair/effects/query-collection.effect.ts Outdated Show resolved Hide resolved
packages/altair-app/src/app/modules/altair/effects/query-collection.effect.ts Outdated Show resolved Hide resolved
@eole1712
Copy link
Contributor Author

Hello @imolorhe
Thanks for the quick review :)

@eole1712 eole1712 requested a review from imolorhe October 5, 2021 16:31
imolorhe
imolorhe approved these changes Oct 8, 2021
View reviewed changes
Copy link
Collaborator

@imolorhe imolorhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@imolorhe imolorhe merged commit 7426a5d into altair-graphql:staging Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imolorhe imolorhe imolorhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eole1712 @imolorhe