Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editor shortcut mapping setting customization #1715

Merged
merged 3 commits into from Oct 17, 2021

Conversation

imolorhe
Copy link
Collaborator

Added editor shortcut mapping setting customization

Fixes

Closes #1704

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

@github-actions
Copy link

github-actions bot commented Oct 17, 2021

Visit the preview URL for this PR (updated for commit 4475275):

https://altair-gql--pr1715-customize-editor-sho-2vv2cf1g.web.app

(expires Sun, 24 Oct 2021 22:22:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@imolorhe imolorhe merged commit 34356b3 into staging Oct 17, 2021
@imolorhe imolorhe deleted the customize-editor-shortcut-mappings branch October 17, 2021 22:56
@SergioSuarezDev
Copy link

Visit the preview URL for this PR (updated for commit 4475275):

https://altair-gql--pr1715-customize-editor-sho-2vv2cf1g.web.app

(expires Sun, 24 Oct 2021 22:22:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Can i test in this url?
I don't get the option to edit the shortcut :(

@imolorhe
Copy link
Collaborator Author

Screenshot 2021-10-18 at 2 13 49 PM

There is no visible option. You have to enable it in the settings yourself.

@SergioSuarezDev
Copy link

ahh! ok ok thanks!

@SergioSuarezDev
Copy link

@imolorhe When do you plan to make a new build to test it? Thanks!

@imolorhe
Copy link
Collaborator Author

After I'm able to get some more features in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment line or various lines using the shortcut in MacOS (CMD+/)
2 participants