add variable checker to full url checker #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imolorhe
requested changes
Nov 12, 2021
| @@ -165,6 +165,12 @@ export const getFullUrl = (url: string) => { | |||
| return url; | |||
| } | |||
|
|
|||
| // regex to test if given string is an environment variable | |||
| const regex = /^{{[a-zA-Z._]+}}$/gm; | |||
There was a problem hiding this comment.
There are several variable regexes in this file. Might be better to reuse one of them instead of creating a new one.
I'd be glad to. I noticed that for testing you're using jest, yet I can't find any examples. Could you point me to one? |
imolorhe
requested changes
Nov 12, 2021
imolorhe
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1735
Checks
yarn test-buildChanges proposed in this pull request:
Added a regex to test if given string is an environment variable. If so - pass it as is, thus fixing the mentioned issue.