Add setting to disable the update available notification (#1) #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add setting to disable the update available notification
imolorhe
reviewed
Nov 23, 2021
| .subscribe((disableUpdateNotification: boolean) => { | ||
| if (!disableUpdateNotification) { | ||
| this.ipc.on('update-available', () => { | ||
| this.notifyService.info('Found new updates!, go to Update to get the latest version', 'Update Found!') |
There was a problem hiding this comment.
Perhaps clicking the notification should have the same effect. i.e. clicking the notification should trigger the update.
There was a problem hiding this comment.
Also just looked at the screenshots. I'm concerned we now have both "Update" and "Check for updates.." menu items. That can get confusing.
There was a problem hiding this comment.
Yep, it's confusing, clicking the notification to get the update seems to be a better idea, if u are ok with that i'll make the change in no time :D
There was a problem hiding this comment.
I've made the change, now there's no "update" option next to "check for updates" and when you click on the notification it downloads the update
* Add setting to disable the update available notification * Changes setting text * lint fix * Add download update on click and remove update option from menu * Removes update option
imolorhe
requested changes
Nov 26, 2021
packages/altair-app/src/app/modules/altair/services/notify/notify.service.ts
Outdated
Show resolved
Hide resolved
imolorhe
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1612
Checks
yarn test-buildChanges proposed in this pull request: