Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative subscription endpoint #1926

Merged
merged 3 commits into from
Jun 11, 2022

Conversation

imolorhe
Copy link
Collaborator

@imolorhe imolorhe commented Jun 11, 2022

Allow relative subscription endpoint

Fixes

Closes #1913

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

The order of execution now is:
- collection pre request script
- (parent collections' pre request scripts)
- query pre request script
- send request/get response
- collection post request script
- (parent collections' post request scripts)
- query post request script

Created query service to contain complex query-related logic.

Closes #1763
@imolorhe imolorhe linked an issue Jun 11, 2022 that may be closed by this pull request
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit c55f911):

https://altair-gql--pr1926-imolorhe-allow-relat-rgqb15ps.web.app

(expires Sat, 18 Jun 2022 21:08:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Base automatically changed from imolorhe/add-request-scripts-in-collections to master June 11, 2022 21:59
@imolorhe imolorhe merged commit ad45156 into master Jun 11, 2022
@imolorhe imolorhe deleted the imolorhe/allow-relative-subscription-endpoint branch June 11, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription endpoint only path (not URL)
1 participant