Auth service unit tests #2229
Merged
Auth service unit tests #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horvathmarton
force-pushed
the
horvathmarton/unit-tests
branch
from
aa8d5bb
to
3c4eb64
Compare
|
@imolorhe I prepared a different PR that covers the remainder of the auth module with tests. Built on this one. Probably it is easier to review the two sequentially. Would you like me to open the two combined or wait until this is merged and then point that on your repo? |
|
One at a time is fine |
imolorhe
requested changes
Jul 20, 2023
Co-authored-by: Samuel <samuelimolo4real@gmail.com>
imolorhe
approved these changes
Jul 21, 2023
Merged
via the queue into
altair-graphql:master
with commit Jul 21, 2023
fb53221
9 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1717
Checks
yarn test-buildChanges proposed in this pull request:
Added unit tests for all public method of altair-api/AuthService that is not a proxy call.
Change the Altair API jest config to only measure coverage for the source folder and ignore data holder files (DTO, input, module, strategy) and configs.