Add remainder auth tests #2233
Merged
Add remainder auth tests #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@horvathmarton do you need to rebase? Looks like this still shows changes from the previous PR |
horvathmarton
force-pushed
the
horvathmarton/auth-tests
branch
from
70d2a34
to
e130d21
Compare
|
@imolorhe true, rebase is done. |
imolorhe
requested changes
Jul 21, 2023
| @@ -0,0 +1,9 @@ | |||
| import { Request, Response } from 'express'; | |||
|
|
|||
| export function mockRequest(props?: object): Request { | |||
There was a problem hiding this comment.
Suggested change
| export function mockRequest(props?: object): Request { | |
| export function mockRequest(props?: Partial<Request>): Request { |
the props should be valid fields in request right? Same treatment for response below.
| it(`should return true if the password matches the provided hash`, async () => { | ||
| // GIVEN | ||
| jest | ||
| .spyOn(bcrypt, 'compare') |
There was a problem hiding this comment.
instead of mocking bcrypt, let's generate a valid hash and hardcode it in the test. You can create a map of password-to-hash that you can use in the tests, if you need multiple.
imolorhe
approved these changes
Jul 22, 2023
Merged
via the queue into
altair-graphql:master
with commit Jul 22, 2023
f433ee1
9 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1717
Checks
yarn test-buildChanges proposed in this pull request:
Added unit tests for all public methods of:
Add dynamic mocks for Express request and response.
Add custom matches for user controller responses.