Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url box improvements #2247

Merged
merged 2 commits into from
Aug 12, 2023
Merged

url box improvements #2247

merged 2 commits into from
Aug 12, 2023

Conversation

imolorhe
Copy link
Collaborator

Fixes

Closes #2244
Closes #2245

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 68b70ae):

https://altair-gql--pr2247-imolorhe-url-box-imp-7gvfosf9.web.app

(expires Sat, 19 Aug 2023 12:59:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 02d6323d75a99e532a38922862e269d63351a6cf

@imolorhe imolorhe added this pull request to the merge queue Aug 12, 2023
Merged via the queue into master with commit 1b7710c Aug 12, 2023
13 checks passed
@imolorhe imolorhe deleted the imolorhe/url-box-improvements branch August 12, 2023 23:40
@ary-modulor
Copy link

FYI: I used to have an env variable in the box like {{url}} which was set to https://example.com. It will become http://https://example.com now.

@imolorhe
Copy link
Collaborator Author

Have you verified that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants