Added deprecated to enums

[imolorhe]

Fixes

#2339
#2338

Checks

• Ran yarn test-build
• Updated relevant documentations
• Updated matching config options in altair-static

Changes proposed in this pull request:

[github-actions]

Visit the preview URL for this PR (updated for commit 325e044):

https://altair-gql--pr2342-imolorhe-add-depreca-h4uu58ox.web.app

_{(expires Sun, 10 Dec 2023 14:27:52 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 02d6323d75a99e532a38922862e269d63351a6cf}

[jaydenseric]

Why was it added to dev dependencies, instead of dependencies? It's used in the published code.

[imolorhe]

Yeah that was by mistake. Thanks for spotting it.

[jaydenseric]

These were semver major changes, but they were published in non semver major version changes.

[imolorhe]

Sorry I'm not sure I follow. You mean I should have published a major version since the change is major?

[jaydenseric]

You mean I should have published a major version since the change is major?

Yes.

Anytime a package makes its peer dependency requirements tighter (require newer versions), it's a breaking change that should be published in a semver major version increment.

Packages that were previously using @koa/router v11 and altair-koa-middleware will now have npm install errors.

[imolorhe]

Got it. I can publish a major version next but I don't think that would fix the issue with those packages, as they would need to update manually.

[jaydenseric]

I'm a bit rusty about the correct way to fix an accidentally major change in a minor/patch release, but maybe what you could do is revert the major changes in an other patch release so that way people using altair-koa-middleware v5 are fixed (for projects not using a lock file , which are most open source published packages, CI will just start working for them again, and npm install for them will start working again), and then redo the major changes correctly in a follow-up v6 release.

[imolorhe]

Sounds good