Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide deprecated doc items (queries, mutations, fields...) #2563

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

JOSU9435
Copy link
Contributor

@JOSU9435 JOSU9435 commented Jun 20, 2024

Fixes

#2220

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

Adds a toggle button in settings to hide deprecated doc items
Screenshot from 2024-06-21 00-19-10

When the toggle button is disabled, the deprecated items should be visible
Screenshot from 2024-06-21 00-20-19

When the toggle button is enabled, the deprecated item should be hidden.
Screenshot from 2024-06-21 00-20-53

Copy link
Collaborator

@imolorhe imolorhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The only thing I would suggest is changing the settings

@imolorhe imolorhe linked an issue Jun 21, 2024 that may be closed by this pull request
@JOSU9435 JOSU9435 requested a review from imolorhe June 23, 2024 10:32
@imolorhe
Copy link
Collaborator

Thanks! Changes look good to me!

@imolorhe imolorhe added this pull request to the merge queue Jun 23, 2024
Merged via the queue into altair-graphql:master with commit 6ebadd5 Jun 23, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to Toggle the visibility of deprecated items
2 participants