-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging #588
Conversation
New Crowdin translations
Update @types/chrome to the latest version 🚀
Update web-ext to the latest version 🚀
Update @types/node to the latest version 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
(keydown)="handleKeydown()" | ||
(blur)="handleBlur()" | ||
(keydown.enter)="handleSubmit()" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
} | ||
.connection-indicator--uncertain { | ||
color: var(--orange-color); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
} | ||
.connection-indicator--connected { | ||
color: var(--green-color); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be followed by an empty line
&:hover { | ||
opacity: 1; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be followed by an empty line
display: inline-block; | ||
opacity: .6; | ||
transition: all .3s ease; | ||
&:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be preceded by an empty line
.url-box__connection-indicator { | ||
display: inline-block; | ||
opacity: .6; | ||
transition: all .3s ease; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.3
should be written with a leading zero as 0.3
padding: 0 10px; | ||
width: 40px; | ||
text-align: center; | ||
& ~ .url-box__input { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be preceded by an empty line
Selector url-box__input
should be written in lowercase with hyphens
Unnecessary parent selector (&)
border-color: var(--primary-color); | ||
} | ||
} | ||
.url-box__input-prepend { | ||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered align-items, bottom, display, left, padding, position, text-align, top, width, z-index
border-color: var(--primary-color); | ||
} | ||
} | ||
.url-box__input-prepend { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selector url-box__input-prepend
should be written in lowercase with hyphens
|
||
&:hover { | ||
border-color: var(--theme-off-border-color); | ||
} | ||
&:focus, &:active { | ||
&:focus, &:active, &:focus-within { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each selector in a comma sequence should be on its own single line
@@ -2,7 +2,7 @@ $url-input-height: 50px; | |||
|
|||
.url-box { | |||
// max-width: 900px; | |||
margin: 0 auto 20px; | |||
margin: 0 auto 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered display, margin, width
&:hover { | ||
text-decoration: underline; | ||
} | ||
.response-time{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge rule .response-time
with rule on line 19
Opening curly brace {
should be preceded by one space
.response-status-code{ | ||
background: rgba(var(--rgb-blue), .1); | ||
} | ||
.response-time{ | ||
display: inline-block; | ||
background: rgba(var(--rgb-black), .5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.5
should be written with a leading zero as 0.5
background: rgba(var(--rgb-cerise), .5); | ||
// color: var(--green-color); | ||
border-radius: 4px; | ||
padding: 0 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
Line should be indented with spaces, not tabs
|
||
.fancy-input-content mark { | ||
// background: var(--cerise-color); | ||
background: rgba(var(--rgb-cerise), .5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.5
should be written with a leading zero as 0.5
} | ||
} | ||
|
||
.fancy-input-content mark { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge rule .fancy-input-content mark
with rule on line 41
position: relative !important; | ||
// padding: 0; | ||
border-radius: 0; | ||
font: inherit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented with spaces, not tabs
display: block !important; | ||
position: relative !important; | ||
// padding: 0; | ||
border-radius: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented with spaces, not tabs
|
||
.fancy-input-element { | ||
display: block !important; | ||
position: relative !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
Line should be indented with spaces, not tabs
} | ||
|
||
.fancy-input-element { | ||
display: block !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
Line should be indented with spaces, not tabs
Properties should be ordered border-radius, display, font, overflow-x, overflow-y, position
// word-wrap: break-word !important; | ||
white-space: pre; | ||
color: transparent !important; | ||
overflow: hidden !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
Line should be indented with spaces, not tabs
No description provided.