Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #588

Merged
merged 23 commits into from
Feb 25, 2019
Merged

Staging #588

merged 23 commits into from
Feb 25, 2019

Conversation

imolorhe
Copy link
Collaborator

No description provided.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

(keydown)="handleKeydown()"
(blur)="handleBlur()"
(keydown.enter)="handleSubmit()"
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

}
.connection-indicator--uncertain {
color: var(--orange-color);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline

}
.connection-indicator--connected {
color: var(--green-color);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

&:hover {
opacity: 1;
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

display: inline-block;
opacity: .6;
transition: all .3s ease;
&:hover {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be preceded by an empty line

.url-box__connection-indicator {
display: inline-block;
opacity: .6;
transition: all .3s ease;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.3 should be written with a leading zero as 0.3

padding: 0 10px;
width: 40px;
text-align: center;
& ~ .url-box__input {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be preceded by an empty line
Selector url-box__input should be written in lowercase with hyphens
Unnecessary parent selector (&)

border-color: var(--primary-color);
}
}
.url-box__input-prepend {
position: absolute;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered align-items, bottom, display, left, padding, position, text-align, top, width, z-index

border-color: var(--primary-color);
}
}
.url-box__input-prepend {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector url-box__input-prepend should be written in lowercase with hyphens


&:hover {
border-color: var(--theme-off-border-color);
}
&:focus, &:active {
&:focus, &:active, &:focus-within {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each selector in a comma sequence should be on its own single line

@@ -2,7 +2,7 @@ $url-input-height: 50px;

.url-box {
// max-width: 900px;
margin: 0 auto 20px;
margin: 0 auto 10px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, margin, width

&:hover {
text-decoration: underline;
}
.response-time{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge rule .response-time with rule on line 19
Opening curly brace { should be preceded by one space

.response-status-code{
background: rgba(var(--rgb-blue), .1);
}
.response-time{
display: inline-block;
background: rgba(var(--rgb-black), .5);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.5 should be written with a leading zero as 0.5

background: rgba(var(--rgb-cerise), .5);
// color: var(--green-color);
border-radius: 4px;
padding: 0 !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used
Line should be indented with spaces, not tabs


.fancy-input-content mark {
// background: var(--cerise-color);
background: rgba(var(--rgb-cerise), .5);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.5 should be written with a leading zero as 0.5

}
}

.fancy-input-content mark {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge rule .fancy-input-content mark with rule on line 41

position: relative !important;
// padding: 0;
border-radius: 0;
font: inherit;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented with spaces, not tabs

display: block !important;
position: relative !important;
// padding: 0;
border-radius: 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented with spaces, not tabs


.fancy-input-element {
display: block !important;
position: relative !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used
Line should be indented with spaces, not tabs

}

.fancy-input-element {
display: block !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used
Line should be indented with spaces, not tabs
Properties should be ordered border-radius, display, font, overflow-x, overflow-y, position

// word-wrap: break-word !important;
white-space: pre;
color: transparent !important;
overflow: hidden !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used
Line should be indented with spaces, not tabs

@imolorhe imolorhe merged commit 114f04f into master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant