Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #607

Merged
merged 58 commits into from
Mar 3, 2019
Merged

Staging #607

merged 58 commits into from
Mar 3, 2019

Conversation

imolorhe
Copy link
Collaborator

@imolorhe imolorhe commented Mar 3, 2019

No description provided.

greenkeeper bot and others added 30 commits February 28, 2019 17:32
Update @types/node to the latest version 🚀
Update karma to the latest version 🚀
Update @types/node to the latest version 🚀
Update @types/node to the latest version 🚀
Added Cookie to allowed headers list.
Added description to keyboard shortcuts.
Closes #599.
--editor-atom-color: #bd93f9;
--editor-property-color: #bd93f9;
--editor-punctuation-color: #f8f8f2;
--editor-cursor-color: #f8f8f2;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #f8f8f2 should only be used in variable declarations; they should be referred to via variable everywhere else.

--editor-keyword-color: #ff79c6;
--editor-atom-color: #bd93f9;
--editor-property-color: #bd93f9;
--editor-punctuation-color: #f8f8f2;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #f8f8f2 should only be used in variable declarations; they should be referred to via variable everywhere else.

--editor-attribute-color: #ff79c6;
--editor-keyword-color: #ff79c6;
--editor-atom-color: #bd93f9;
--editor-property-color: #bd93f9;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #bd93f9 should only be used in variable declarations; they should be referred to via variable everywhere else.

--editor-variable-color: #50fa7b;
--editor-attribute-color: #ff79c6;
--editor-keyword-color: #ff79c6;
--editor-atom-color: #bd93f9;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #bd93f9 should only be used in variable declarations; they should be referred to via variable everywhere else.

--editor-number-color: #bd93f9;
--editor-variable-color: #50fa7b;
--editor-attribute-color: #ff79c6;
--editor-keyword-color: #ff79c6;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #ff79c6 should only be used in variable declarations; they should be referred to via variable everywhere else.

--theme-off-bg-color: #303240;
--theme-font-color: #f8f8f2;
--theme-off-font-color: #f8f8f2;
--theme-border-color: #40414d;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #40414d should only be used in variable declarations; they should be referred to via variable everywhere else.

--theme-bg-color: #282a36;
--theme-off-bg-color: #303240;
--theme-font-color: #f8f8f2;
--theme-off-font-color: #f8f8f2;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #f8f8f2 should only be used in variable declarations; they should be referred to via variable everywhere else.

.dracula-theme {
--theme-bg-color: #282a36;
--theme-off-bg-color: #303240;
--theme-font-color: #f8f8f2;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #f8f8f2 should only be used in variable declarations; they should be referred to via variable everywhere else.


.dracula-theme {
--theme-bg-color: #282a36;
--theme-off-bg-color: #303240;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #303240 should only be used in variable declarations; they should be referred to via variable everywhere else.

}

.dracula-theme {
--theme-bg-color: #282a36;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #282a36 should only be used in variable declarations; they should be referred to via variable everywhere else.
Properties should be ordered --editor-atom-color, --editor-attribute-color, --editor-comment-color, --editor-cursor-color, --editor-keyword-color, --editor-number-color, --editor-property-color, --editor-punctuation-color, --editor-string-color, --editor-variable-color, --header-bg-color, --theme-bg-color, --theme-border-color, --theme-font-color, --theme-off-bg-color, --theme-off-border-color, --theme-off-font-color

--editor-cursor-color: var(--blue-color);
}

.dracula-theme {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule set contains (17/10) properties

}
.settings-shortcut-key {
background: var(--theme-off-bg-color);
padding: 3px 5px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered background, border-radius, margin-right, padding


.settings-shortcut-category-title {
text-transform: uppercase;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

@@ -1,5 +1,5 @@
.header {
box-shadow: 0 5px 12px 2px rgba(var(--rgb-black), .1);
box-shadow: 0 0px 5px 2px rgba(var(--rgb-black), 0.1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered background, box-shadow
0px should be written without units as 0

}
.cm-def{
color: var(--orange-color);
.cm-def {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

}
.cm-string{
color: var(--theme-font-color);
.cm-string, .cm-string-2, .cm-string-3 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each selector in a comma sequence should be on its own single line
Line should be indented 2 spaces, but was indented 4 spaces

}
.cm-attribute{
color: var(--green-color);
.cm-attribute {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

.cm-atom{
color: var(--theme-font-color);
.cm-s-default {
.cm-atom {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

@@ -15,7 +15,7 @@
}
}
.CodeMirror-cursor{
border-left-color: var(--blue-color);
border-left-color: var(--editor-cursor-color);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

background: var(--theme-bg-color);
color: var(--theme-font-color);

}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

background: var(--theme-bg-color);
color: var(--theme-font-color);
}
.stack-view .stack-block-expandable.on-focus:not(.stack-block-expanded) > .stack-block-label,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

.stack-view .stack-block-expanded > .stack-block-content {
background: var(--theme-bg-color);
color: var(--theme-font-color);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

}
}
}
.stack-view .stack-block-expanded > .stack-block-label,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

}
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

}
}
&:hover {
.stack-block-label, .stack-block-content {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each selector in a comma sequence should be on its own single line
Selector should have depth of applicability no greater than 2, but was 3

.stack-block-label, .stack-block-content {
background: var(--theme-bg-color);
color: var(--theme-font-color);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

background: var(--theme-bg-color);
color: var(--theme-font-color);
border-color: var(--theme-border-color);
.stack-block-label, .stack-block-content {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each selector in a comma sequence should be on its own single line
Rule declaration should be preceded by an empty line


.stack-view {
background: var(--theme-bg-color);
color: var(--theme-font-color);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered background, border-color, color

background: var(--theme-border-color);
}
&.active {
color: var(--primary-color);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered background, color

&:hover {
color: var(--theme-font-color);
background: var(--theme-border-color);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

@imolorhe imolorhe merged commit 6a838a6 into master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant