Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #683

Merged
merged 54 commits into from Mar 24, 2019
Merged

Staging #683

merged 54 commits into from Mar 24, 2019

Conversation

imolorhe
Copy link
Collaborator

No description provided.

imolorhe and others added 30 commits March 16, 2019 16:02
Update @types/jasmine to the latest version 🚀
Update @types/jasmine to the latest version 🚀
Added link to settings pane in settings dialog.
Closes #676.
@request-info
Copy link

request-info bot commented Mar 24, 2019

The maintainers of this repository would appreciate it if you could provide more information.

@@ -17,6 +17,9 @@ app-query-collections {
flex-grow: 0;
}
}
.query-collections__actions--right {
float: right;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

@@ -17,6 +17,9 @@ app-query-collections {
flex-grow: 0;
}
}
.query-collections__actions--right {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector query-collections__actions--right should be written in lowercase with hyphens

background-position: 100% 50%
}
100% {
background-position: 0% 50%
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaration should be terminated by a semicolon

50% {
background-position: 100% 50%
}
100% {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented with spaces, not tabs

}
50% {
background-position: 100% 50%
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

background: linear-gradient(-45deg, var(--primary-color), var(--secondary-color));
background-size: 200% 200%;
background-clip: text;
animation: bg-gradient 5s ease infinite;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

transition-duration: 0.3s;
background: linear-gradient(-45deg, var(--primary-color), var(--secondary-color));
background-size: 200% 200%;
background-clip: text;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

color: transparent;
transition-duration: 0.3s;
background: linear-gradient(-45deg, var(--primary-color), var(--secondary-color));
background-size: 200% 200%;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

position: relative;
color: transparent;
transition-duration: 0.3s;
background: linear-gradient(-45deg, var(--primary-color), var(--secondary-color));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

.window-loader__content {
position: relative;
color: transparent;
transition-duration: 0.3s;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

@@ -18,3 +18,23 @@
.window-loader--show{
@include show-transition;
}
.window-loader__content {
position: relative;
color: transparent;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

@@ -18,3 +18,23 @@
.window-loader--show{
@include show-transition;
}
.window-loader__content {
position: relative;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces
Properties should be ordered animation, background, background-clip, background-size, color, position, transition-duration

@@ -18,3 +18,23 @@
.window-loader--show{
@include show-transition;
}
.window-loader__content {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector window-loader__content should be written in lowercase with hyphens

background-size: 200% 200%;
background-clip: text;
animation: bg-gradient 5s ease infinite;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

@@ -61,6 +61,15 @@ app-doc-viewer {
.show-loader{
@include show-transition;
}
.app-doc-loader-content {
position: relative;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered animation, background, background-clip, background-size, color, position, transition-duration

@@ -8,6 +8,12 @@ button{
.icon-button {
border: 0;
border-radius: 4px;
background: var(--theme-bg-color);
color: var(--theme-font-color);
transition: all .3s ease;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces
.3 should be written with a leading zero as 0.3

@@ -8,6 +8,12 @@ button{
.icon-button {
border: 0;
border-radius: 4px;
background: var(--theme-bg-color);
color: var(--theme-font-color);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

@@ -8,6 +8,12 @@ button{
.icon-button {
border: 0;
border-radius: 4px;
background: var(--theme-bg-color);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

'Content-Security-Policy': [`script-src 'self' 'sha256-1Sj1x3xsk3UVwnakQHbO0yQ3Xm904avQIfGThrdrjcc='; object-src 'self';`]
}
});
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw ')'.
Missing semicolon.

// Setting CSP
'Content-Security-Policy': [`script-src 'self' 'sha256-1Sj1x3xsk3UVwnakQHbO0yQ3Xm904avQIfGThrdrjcc='; object-src 'self';`]
}
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected ')' and instead saw '}'.
Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw ')'.
Missing semicolon.

@imolorhe imolorhe merged commit 3f75353 into master Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant