Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: simplifies and tests #4

Merged
merged 9 commits into from Nov 5, 2016
Merged

WIP: simplifies and tests #4

merged 9 commits into from Nov 5, 2016

Conversation

stsievert
Copy link
Member

@stsievert stsievert commented Oct 29, 2016

Work to be done before merge:

  • implement new dashboards (basics implemented, screenshot below)
  • rewrite dashboards: "encode [column] as [encoding]" (i.e., "encode species as color")
  • rework the data flow (and untangle the spaghetti code)
  • allow other specific parameters in advanced (i.e., in scale allow kwargs bin, zero, etc).
  • allow global parameters to be set (i.e., for heatmaps allow applyColorToBackground)
  • implement command to get Altair command out to generate the shown plot
  • test

screen shot 2016-10-29 at 3 01 33 pm

stsievert pushed a commit that referenced this pull request Oct 30, 2016
and other enhancements in PR #4
@stsievert
Copy link
Member Author

All the tasks are complete except one (detail below). This PR is nearly ready for merge and I feel the current implementation is fairly stable.

@jakevdp can I hear your thoughts on naming? I only expose interact_with(df, ndims=3, show=True) but it also possible to access the class behind all the widget, Interact which has minimal public elements.

I implement 13 tests, some doctests and some testing interfacing with Altair (can't test UI yet, #5 is an example bug). I implemented the tests in a notebook because of an issue (jupyter-widgets/ipywidgets#13?) that means I can't run tests from the command line and only in Jupyter notebook. While not ideal, I've interfaced these notebook tests with pytest and Travis CI.


Screenshots

General interface (an older GIF can be seen on the README for this branch):
screen shot 2016-10-30 at 10 02 42 pm

When the encoding options are expanded:
screen shot 2016-10-30 at 10 03 40 pm

When the mark options are expanded:
screen shot 2016-10-30 at 10 03 05 pm

I have filed jupyter-widgets/ipywidgets#861 about the checkbox width.

@jakevdp
Copy link
Member

jakevdp commented Nov 2, 2016

Quick question – would there be any way to make it so the ndims is not pre-specified? I imagine it being rather annoying if you're exploring a dataset, find you need one more dimension, and then have to re-run the cell and re-enter everything you've done.

Scott Sievert added 6 commits November 4, 2016 22:42
DOC: rewrites README to point to Vega
TST: adds some tests, UI: adds some notebook output
public components of Interface:
- plot, settings
- show, df

MAINT: makes Interact.update "private"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants