Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging #152

Merged
merged 16 commits into from
Oct 3, 2019
Merged

Add debug logging #152

merged 16 commits into from
Oct 3, 2019

Conversation

MarkusG
Copy link
Contributor

@MarkusG MarkusG commented Oct 3, 2019

This addresses #113.

  • Add a log domain in meson.build
  • Add logging for the following:
    • Playerctl version at startup
    • Found players
    • Command execution
    • Warning for mpris;trackid not being a D-Bus object reference
    • Player properties changed events
    • Warning when playback status is not set on track change
    • Capitalize warning for unknown playback state
    • Player seeked event
    • Warning for Spotify not using the D-Bus property cache
    • Warning for D-Bus socket address when attempting to list player names on a bus
    • Getting bus names for player names, and which method is being used
    • Warning for bus address being set incorrectly in player init
    • Initializing cache for player

@acrisci
Copy link
Member

acrisci commented Oct 3, 2019

Cool looks like a pretty good start.

You have some whitespace issues that need to be fixed.

Works with this:

G_MESSAGES_DEBUG=playerctl ./build/playerctl/playerctl

@MarkusG
Copy link
Contributor Author

MarkusG commented Oct 3, 2019

Whitespace issues corrected in df9a465

@acrisci
Copy link
Member

acrisci commented Oct 3, 2019

👍

@acrisci acrisci merged commit cc1431c into altdesktop:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants