Add bash completions

[MarkusG]

Create the /completions directory and add a completion script for bash

This addresses #127, for bash at least

Requesting advice on how to fully implement this into playerctl - whether it should be hard-coded into the binary or read from a file.

[acrisci]

I want to keep it in the repo as a file so it's easier to edit and I might want to distribute the file as well for the use case where people want to source the file instead of run the binary.

To do this, there are two options. You could either template the completions in with meson or follow these instructions to convert the files into something that can be linked in.

[MarkusG]

Applied requested changes to the completion script and edited build files to install to /etc/bash_completion.d/playerctl.bash

[acrisci]

Hey @knowledgejunkie we're getting bash completions. Do you know of any guidelines on how to package them?

[knowledgejunkie]

I'm not aware of specific guidelines on how to package them in source. Many projects that include bash/zsh completions (in e.g. contrib/completions/*) leave it up to the end user to manually install them (per user or system-wide). Other projects might make it part of the make install process to make them available to all users.

Distros usually have special tooling in the packaging build system to ensure completions get installed into the correct location (e.g. on Debian we have the dh_bash-completion tool which installs to /usr/share/bash-completion/completions/) to make them available to all users on the system.

[acrisci]

Thanks. From what I can see based on that discussion, bash completions are usually supposed to go in a separate package. So we won't install them by default and leave it up to the packagers to decide how to handle it.

[MarkusG]

Sounds good to me. Took the completions out of the package.

[acrisci]

👍 👍