Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EliteDangerous.announceR2RMappingCandidates independent of [System visits] check in EliteDangerous.EDDI Jumped #61

Closed
SiIason opened this issue Aug 15, 2020 · 2 comments
Closed

Make EliteDangerous.announceR2RMappingCandidates independent of [System visits] check in EliteDangerous.EDDI Jumped #61

SiIason opened this issue Aug 15, 2020 · 2 comments
Assignees
@alterNERDtive
Labels
bug Something isn't working done implemented, but not merged into release yet EliteAttack
Milestone
3.0.1

Comments

@SiIason
Copy link

SiIason commented Aug 15, 2020

Noticed tonight some systems not scanning/honking, and its because I've been via then a couple of times.
This is fine, makes sense but also noticed I wasn't been told of R2R candidates that I previously skipped.

Think if you have R2R on in the settings then this function/check should fire for every system known about or not.

NB: I haven't checked if this is also the case for the function matching spanch and edsm data (as that would also be handy having separate; regardless of honk imo)
@alterNERDtive alterNERDtive self-assigned this Aug 15, 2020
@alterNERDtive alterNERDtive added the bug Something isn't working label Aug 15, 2020
@alterNERDtive alterNERDtive added this to the 3.0.1 milestone Aug 15, 2020
@alterNERDtive
Copy link
Owner

Yeah, that should belong into Jumped not Discovery scan. Good catch.

NB: I haven't checked if this is also the case for the function matching spanch and edsm data

Data is requested on Jumped and then we just hope that it has returned something (or errored out) by the time the Discovery scan hits 🤷

… I have run into a bunch of instances lately with EDSM timing out / taking very long to answer and bodies being checked against last system’s count :-/ (In fact, lemme fix that real quick …)

@alterNERDtive alterNERDtive mentioned this issue Aug 15, 2020
Open
alterNERDtive added a commit that referenced this issue Aug 15, 2020
@alterNERDtive
EliteDangerous: Discovery scan event more reslient
75ecc02 
properly realizes now if EDSM has been slow to respond and body count
hasn’t been pulled for the current system yet.

see comment on #61
@alterNERDtive alterNERDtive mentioned this issue Aug 17, 2020
Open
@alterNERDtive
Copy link
Owner

Caveat: moving this to Jumped will probably make #64 worse.

@alterNERDtive alterNERDtive added EliteAttack done implemented, but not merged into release yet labels Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alterNERDtive alterNERDtive

Labels
bug Something isn't working done implemented, but not merged into release yet EliteAttack
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
2 participants
@SiIason @alterNERDtive