Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a proper error message for missing binds #2

Closed
alterNERDtive opened this issue Oct 24, 2020 · 2 comments
Closed

Add a proper error message for missing binds #2

alterNERDtive opened this issue Oct 24, 2020 · 2 comments
Assignees
@alterNERDtive
Labels
enhancement New feature or request

Comments

@alterNERDtive
Copy link
Owner

That usually happens when a default binding is used. StartPreset.start will have the bindings name, but no corresponding .binds file will exists.

Needs some verbatim about using a custom control scheme.
@alterNERDtive alterNERDtive self-assigned this Oct 24, 2020
@alterNERDtive alterNERDtive added the enhancement New feature or request label Oct 24, 2020
@alterNERDtive
Copy link
Owner Author

Will now log an ERROR to the VA log if the binds file is flat out missing (e.g. because a default preset is used).

Still to do: list of missing bindings. Not sure if I should dump that (potentially massive) list into the log every time bindings are read, or only do it on demand through a dedicated plugin context.

@alterNERDtive
Copy link
Owner Author

I went with

  • reporting missing keys in the key map when loading bindings
  • having a separate missingbinds context to handle reporting missing binds on demand (because there are A LOT of them!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alterNERDtive alterNERDtive

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alterNERDtive