Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color code 90 (dark gray) nearly invisible in osx terminal / iterm2 #164

Open
vincentcr opened this issue Dec 23, 2011 · 18 comments
Open

color code 90 (dark gray) nearly invisible in osx terminal / iterm2 #164

vincentcr opened this issue Dec 23, 2011 · 18 comments

Comments

@vincentcr
Copy link

color code 90 (dark gray) is nearly invisible in osx terminal / iterm2.

in a "standard" terminal palette this code shows as dark gray. but in dark solarized it is almost exactly the same as the background color.

@cdlm
Copy link

cdlm commented Dec 24, 2011

That's intended, no? base02 is supposed to have low contrast with base03.
I'd suggest comparing with screenshots on the website, checking your display profile, or submitting a screenshot of yours if you really think it looks wrong.

@vincentcr
Copy link
Author

i'm only trying to say that many applications use it as a foreground color (because normally dark gray would be amply visible against either black or white), and so that it should have sufficient contrast against the default background to be legible. as it is now it is not the case.

@cgarvis
Copy link

cgarvis commented Aug 21, 2012

iTerm2 has the contrast set to the lowest. If you increase this, you can see color code 90. Still not awesome, but works.

@Dieterbe
Copy link

i think this is a dup of #8

@suan
Copy link

suan commented Jan 28, 2013

@cgarvis That's a pretty good solution - it should be added to the iterm2-solarized README.

@necolas
Copy link

necolas commented Apr 29, 2013

Related: mochajs/mocha#802

@mbrevda
Copy link

mbrevda commented Sep 8, 2013

Contrast fixed it for me, thanks @cgarvis !

@gerardo8a
Copy link

After reading for more than 30 mins for solutions this is the best one! +100

@carlthuringer
Copy link

👍 Increase contrast a little fixed it.

@foxx
Copy link

foxx commented Mar 31, 2015

This indeed fixes the problem for me, is there any way this could be made the default value or explained somewhere in the README? Took a while to figure this out, nearly stopped using solarized :/

@wmayner
Copy link

wmayner commented Jul 14, 2015

Ditto @foxx

@carlthuringer
Copy link

@foxx Unless there's a hidden value for the itermcolors file format, exporting after changing the contrast seems to indicate that the contrast setting is not part of the itermcolors file and cannot be defaulted.

@mingchaoyan
Copy link

Contrast fixed it for me, thanks @cgarvis !

@kanerogers
Copy link

@cgarvis: Thank you from the future! ❤️

@wenwuwu
Copy link

wenwuwu commented Jun 16, 2016

@cgarvis: Thank you. Contrast fixed it.

@mangelsnc
Copy link

@cgarvis awesome, thanks!

@revolter
Copy link

revolter commented Nov 24, 2017

Changing the contrast breaks Bullet Train.

@Pyrolistical
Copy link

this was fixed in vscode microsoft/vscode#146243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests