Checks the existence of a public getId method

alterphp · Dec 2, 2019 · f24ccc0 · f24ccc0
1 parent 55aa7fb
commit f24ccc0
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/Helper/EmbeddedListHelper.php b/src/Helper/EmbeddedListHelper.php
@@ -137,7 +137,17 @@ public function guessDefaultFilter(string $entityFqcn, string $parentEntityPrope
                     $relatedItems = PropertyAccess::createPropertyAccessor()->getValue(
                         $parentEntity, $parentEntityProperty
                     );
-                    $itemIds = $relatedItems->map(function ($entity) {
+                    $itemIds = $relatedItems->map(function (object $entity) {
+                        $hasGetIdMethod = false;
+                        try {
+                            $reflGetIdMethod = new \ReflectionMethod($entity, 'getId');
+                            $hasGetIdMethod = $reflGetIdMethod->isPublic();
+                        } catch (\ReflectionException $e) {}
+
+                        if (!$hasGetIdMethod) {
+                            throw new \RuntimeException('EmbeddedListHelper requires a public `getId` method on root entity in order to guess filters to apply!');   
+                        }
+
                         return $entity->getId();
                     });