Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent <i> to show full page #149

Closed
wants to merge 2 commits into from
Closed

Prevent <i> to show full page #149

wants to merge 2 commits into from

Conversation

GeraldGat
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.184% when pulling 5db9d27 on GeraldGat:patch-1 into cc256be on alterphp:master.

@alterphp
Copy link
Owner

Are you sure you want to merge into master ? In your issue description (#148) you mentionned you are using 1.x branch ?

@GeraldGat
Copy link
Author

I think I made a mistake, first time I use pull request ^^'

@GeraldGat GeraldGat closed this Jul 24, 2019
@alterphp
Copy link
Owner

alterphp commented Jul 24, 2019

In master branch, it has been fixed by replacing e.target.href by e.currentTarget.href. Please try this to get aligned.

cf. https://github.com/alterphp/EasyAdminExtensionBundle/pull/118/files

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants