-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Controller now use trait for better use in EasyAdmin #176
Conversation
…with other extensions
I contacted the author of Wandi Extension Bundle and he accepted a similar PR so now it's very easy to use both extension :
Now it's very easy to use both extension, I just had to override the isActionAllowed used by both extensions and everything is working fine. |
Thank you @DylanKas for this useful work ! For now it's on master, i'll tag it soon. |
@DylanKas I was sure I merged it 3 days ago but I did not... It's merged to master now. |
It's fine :) Will you tag it soon ? |
tagged as v3.0.1 |
This pull request modify the EasyAdminController to use a trait and make it easier to use other extension with EasyAdmin. (Example: WandiParis/EasyAdminPlusBundle)
It has been tested on a local projet that use both Wandi and AlterPHP extensions.
I will try to contact other developer such as Wandi to try and do the same and it will make it better for EasyAdmin users to use multiple extensions.