Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ManyToMany relations in embedded lists #53

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

rimi-itk
Copy link
Contributor

Resolves #52

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 90.024% when pulling 301bdf5 on rimi-itk:Issue-52 into dece12c on alterphp:master.

@alterphp
Copy link
Owner

Hi @rimi-itk !

It looks good. I merge into master, then write a test to avoid regression and then tag it.

Thanks for this contribution !

@alterphp alterphp merged commit 8630364 into alterphp:master Aug 29, 2018
@rimi-itk
Copy link
Contributor Author

Thank you! Sorry about decreasing the code coverage …

@alterphp
Copy link
Owner

code coverage will increase with the test, no worries. Anyway, code coverage is not a real quality indicator (what is covered is not necessarly tested).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants