Security for all type "except entity" if has rol only hide menu #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alterphp
reviewed
Nov 2, 2018
src/Helper/MenuHelper.php
Outdated
| else if ( | ||
| 'route' === $entry['type'] | ||
| && isset($entry['role']) | ||
| && !$this->adminAuthorizationChecker->isEasyAdminGranted( |
There was a problem hiding this comment.
Please use Symfony security.authorization_checker service. AdminAuthorizationChecker is intended to check access regarding an entity EasyAdmin config. You can not invent a list action role to deal with this case.
There was a problem hiding this comment.
Adding a test to cover the use case would be really kindful too ;-)
There was a problem hiding this comment.
Necessary? Now it's very simple and uses authorizationChecker:
if (
'route' === $entry['type']
&& isset($entry['role'])
&& !$this->authorizationChecker->isGranted($entry['role'])
)
gonzaloalonsod
changed the title
gonzaloalonsod
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security for type "route" only hide menu