Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list filter config field class #79

Closed
wants to merge 3 commits into from
Closed

list filter config field class #79

wants to merge 3 commits into from

Conversation

gonzaloalonsod
Copy link
Contributor

  • { property: 'status', type_options: { attr: { class: 'col-sm-3' } } }
  • { property: 'organization', type_options: { attr: { class: 'col-sm-9' } } }

- { property: 'status', type_options: { attr: { class: 'col-sm-3' } } }
- { property: 'organization', type_options: { attr: { class: 'col-sm-9' } } }
@coveralls
Copy link

coveralls commented Nov 16, 2018

Coverage Status

Coverage decreased (-0.1%) to 90.656% when pulling b161c59 on gonzakpo:master into 2c3b667 on alterphp:master.

@alterphp
Copy link
Owner

Hi @gonzakpo !

Can you post the generated HTML code for the whole list filters <div> ? I have a doubt about the class attribute that may affects the input itself (and not only its container).

@gonzaloalonsod
Copy link
Contributor Author

gonzaloalonsod commented Nov 21, 2018

@alterphp
The value is default col-sm-4, now it allows to configure.
Does not affect the entry.
filtro

@alterphp
Copy link
Owner

HI @gonzakpo !

  • This breaks submit button full height. Why did you change the whole HTML structure ? Only line 91 is useful regarding your intention (modify filter fields covered columns).

  • As I expected, the input itself takes the class... (not only the container, the input, select, etc). That's why I asked you to post the generated HTML code...

@gonzaloalonsod
Copy link
Contributor Author

gonzaloalonsod commented Nov 22, 2018

if you use bootstrap <div class = "col"> it goes inside <div class = "row"> always

@alterphp
Copy link
Owner

I just pushed a better bootstrap 3 integration for the list filters form. It keeps full height on submit button.

But still no good solution for your intention.

@gonzaloalonsod
Copy link
Contributor Author

i will see

@@ -34,6 +34,7 @@ protected function isActionAllowed($actionName)
switch ($actionName) {
// autocomplete action is mapped to list action for access permissions
case 'autocomplete':
break;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to the PR, so please don't mix many purposes in the same PR.

And moreover, it is wrong.

@alterphp alterphp closed this Nov 30, 2018
@alterphp
Copy link
Owner

Closed as no solution has emerged.

@gonzaloalonsod
Copy link
Contributor Author

right way:
http://php.net/manual/en/control-structures.switch.php

I will create a new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants