Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike - Compute rolling windows features for time series #2510

Closed
freddyaboulton opened this issue Jul 14, 2021 · 3 comments · Fixed by #3028
Closed

Spike - Compute rolling windows features for time series #2510

freddyaboulton opened this issue Jul 14, 2021 · 3 comments · Fixed by #3028
Assignees
Labels
spike To generate additional issues and kick off a sprint.

Comments

@freddyaboulton
Copy link
Contributor

The outcome of this issue is a design document detailing how we can augment the existing set of time series transformers with new time series transformations.

I'd like us to prioritize leveraging ts_fresh because:

  1. These primitives are time-aware and respect series indicators - quickstart
  2. Support forecasting with rolling transformations - demo
  3. There's an integration with sktime - docs
@freddyaboulton freddyaboulton added the spike To generate additional issues and kick off a sprint. label Jul 14, 2021
@freddyaboulton freddyaboulton changed the title Spike - Add more time series feature engineering Spike - Enhance time series feature engineering Sep 1, 2021
@freddyaboulton
Copy link
Contributor Author

freddyaboulton commented Sep 1, 2021

I just filed #2733 which is related to this.

Another related thought is to make max_delay an optional parameter to increase the amount of data that can be used to generate features.

@freddyaboulton
Copy link
Contributor Author

freddyaboulton commented Oct 19, 2021

Progress so far:

We've been chatting with the featuretools team about adding rolling window transform primitives to featuretools. Current design is here

@freddyaboulton freddyaboulton changed the title Spike - Enhance time series feature engineering Spike - Compute rolling windows features for time series Oct 25, 2021
@freddyaboulton
Copy link
Contributor Author

freddyaboulton commented Oct 26, 2021

As discussed at our synch, we don't need to wait for featuretools to add this functionality to close out this issue.

We can make progress by writing a simple rolling average component in base pandas that we can then swap out for the more mature featuretools implementation.

To close out this issue we should therefore:

  • Write a design document detailing how to add a component that will compute a single rolling average feature. This document should detail how we can eventually swap out the logic for the featuretools primitives talked about in the design document above.
  • Implement that design document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike To generate additional issues and kick off a sprint.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant