Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete TargetTransformer class #2687

Closed
freddyaboulton opened this issue Aug 24, 2021 · 0 comments · Fixed by #2833
Closed

Delete TargetTransformer class #2687

freddyaboulton opened this issue Aug 24, 2021 · 0 comments · Fixed by #2833
Assignees
Labels
enhancement An improvement to an existing feature. refactor Work being done to refactor code.

Comments

@freddyaboulton
Copy link
Contributor

The TargetTransformer parent class was added when the pipeline/component graph inverse_transform method was added. We felt it was necessary to introduce this parent class because our component graph was not 100% ready to handle components that modified the target, e.g. we still supported from_list for the component graph even though lists are an ambiguous representation for pipelines with target transformers and it was possible to grab the .y from a component that did not modify the target.

You can see this thread from the original PR for context: #2256 (comment)

The TargetTransformer class is no longer necessary because of:
#2563
#2556
#2662

@freddyaboulton freddyaboulton added enhancement An improvement to an existing feature. refactor Work being done to refactor code. labels Aug 24, 2021
@bchen1116 bchen1116 self-assigned this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature. refactor Work being done to refactor code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants