New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include target column name and class labels in predict/predict_proba output #645
Comments
First question here: do we support If we don't support |
pd.Series
/pd.DataFrame
from predict/predict_proba
Did some testing, and it looks like we don't support categorical dtypes, and expect numerical target values. More specifically:
Here's some snippets of code I used to test, primarily using sklearn's datasets: For binary classification:
For multiclass classification:
In both cases, , we get the same error as reported in #828 due to our check for label leakage not being able to handle non-numeric datatypes. But even when we skip data checks using
|
@angela97lin I just added this to the epic #886 for the July milestone. Should we move this back to Development Backlog? And I'd say please either unassign yourself from this issue, or assign yourself to the epic #886 if you want to tackle it! |
(forgot to post from this morning:) @angela97lin thank you for the thorough explanation! So, for classification, we don't support:
In the good news category, we may currently support boolean type, but we need to verify and unit-test that. Well, it seems like we should fix this! 😂 I just filed epic #886 for this, and moved this and #215 into that epic. Let's get this done for the July release. |
#236 covers standardizing our predict methods to return
pd.Series
orpd.DataFrame
.A note on this from the usability blitz: Once #236 is done, we need to populate the
name
field onpd.Series
or column name onpd.DataFrame
with the users' target column name.And, for
predict_proba
output, which can haven
columns, one for each class value in the target, we should label each of those with the corresponding class value.The text was updated successfully, but these errors were encountered: