Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding new scalar comparison primitives for Datetime and Ordinal column types #2435

Open
thehomebrewnerd opened this issue Jan 4, 2023 · 0 comments

Comments

@thehomebrewnerd
Copy link
Contributor

In PR #2434 Datetime and Ordinal inputs were removed from the valid input types for four comparison primitives. This was done due to errors that could be encountered during feature value calculation. We should consider adding new primitives to replace the lost functionality, if these types of comparisons are needed.

The Ordinal comparison primitives might be too specific and may not be necessary, but the datetime comparison primitives could be useful.

Some primitives to add could include (naming could be improved):
GreaterThanDate
GreaterThanOrEqualToDate
LessThanDate
LessThanOrEqualToDate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant