Avoid using NetBIOS when direct_tcp is set to True

[frafra]

Fix #24.

[codecov]

Codecov Report

Merging #25 (5c5047d) into master (4882466) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          444       447    +3     
=========================================
+ Hits           444       447    +3     

Impacted Files	Coverage Δ
fs/smbfs/smbfs.py	100.00% <ø> (ø)
fs/smbfs/utils.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4882466...5c5047d. Read the comment docs.

[frafra]

An alternative solution would be to set NETBIOS to None in case direct_tcp is True and then alter get_hostname_and_ip to avoid using NetBIOS.

[althonos]

Hi @frafra, Sorry for the delay!

I'd be in favor of the following solution:

• make get_hostname_and_ip accept None for the netbios argument, and only run lines 78-90 if netbios is not None.
• make SMBFS.__init__ pass its NETBIOS instance only if direct_tcp is False:

   self._server_name, self._server_ip = utils.get_hostname_and_ip(
       host, 
       None if direct_tcp else self.NETBIOS,
       timeout=timeout,
       name_port=name_port
   )

This way we can keep the code duplication minimal, while still supporting swapping the IP and host in the input tuple, and properly report if one of the two is missing like before.

[frafra]

@althonos no worries :)

It seems OK to me now.

[althonos]

Thanks! I added some extra tests just to make sure it works as expected.