Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotation + repr fixes #4

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Type annotation + repr fixes #4

merged 1 commit into from
Aug 16, 2023

Conversation

valentynbez
Copy link
Contributor

@valentynbez valentynbez commented Aug 13, 2023

  • improved __repr__ for FullResult
  • changed typing info (for better docs)

Copy link
Owner

@althonos althonos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the __repr__ fix!

pyopal/_opal.pyi Outdated Show resolved Hide resolved
pyopal/_opal.pyx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5664a98) 80.29% compared to head (1354e03) 80.29%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files           3        3           
  Lines         411      411           
=======================================
  Hits          330      330           
  Misses         81       81           
Flag Coverage Δ
CPython 80.29% <0.00%> (ø)
Linux 80.29% <0.00%> (ø)
OSX 80.04% <0.00%> (ø)
v3.10 80.29% <0.00%> (ø)
v3.11 80.29% <0.00%> (ø)
v3.6 80.29% <0.00%> (ø)
v3.7 80.29% <0.00%> (ø)
v3.8 80.29% <0.00%> (ø)
v3.9 80.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pyopal/_opal.pyx 79.85% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@althonos althonos merged commit 385ecac into althonos:main Aug 16, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants